EllisLab text mark
Advanced Search
     
File validation conundrum
 
LeonardoGaiero
Posted: 04 November 2010 06:22 AM   [ Ignore ]
Joined: 2010-08-19
17 posts

Greetings. I have a situation where I need to be able to perform validation on a file upload, which has to happen simultaneously with a database operation; however, I have hit a brick wall with validating the upload before actually altering the DB data. I basically need to be able to do the following:

- Validate the POST part of the form input;
- Validate the file itself;
- Echo any errors about either the file OR the DB data;
- If everything’s OK, perform the actual operations.

Please let me state beforehand that changing the process can only be done to a certain extent, and that I don’t want to separate the upload from the database operation: the user needs to see everything in a single form, and work from there.

Now, I have identified a couple of possible routes to go about this: since I noticed that CI relies on PHP’s native upload functions to verify the validity of any given file (ie, attempts to do the upload and posts the results), I could either try to “fake” the file upload, so to speak, or manually hack together a validation routine.

Apparently, the former requires me to muck around with the PHP engine itself, whereas the second route is rather error-prone; which option would be best? is there anything better out there, short of doing the upload and deleting the file if the DB insertion fails? Many thanks in advance for any and all useful insight.
 
umefarooq
Posted: 04 November 2010 07:15 AM   [ Ignore ]   [ # 1 ]   [ Rating: 0 ]
Avatar
Joined: 2008-09-11
758 posts

hope this will help you to solve your problem check the file validation

http://devbro.com/testing/ci_form_validation/

 Signature 

CI,JQuery,Google Maps | widget with CI loader | Thumbnail, Image Resize, Image Crop Helper | CI shortcode
 
LeonardoGaiero
Posted: 04 November 2010 07:31 AM   [ Ignore ]   [ # 2 ]   [ Rating: 0 ]
Joined: 2010-08-19
17 posts
umefarooq - 04 November 2010 11:15 AM

hope this will help you to solve your problem check the file validation

http://devbro.com/testing/ci_form_validation/

Thanks for the link, that looks rather useful; however, I figured that things should be much simpler than they actually are, so I decided I’d just make the DB data mandatory and the file data optional.

If an user tries to upload a file without inserting änything in a provided textarea, the application stops at form validation, and only performs the upload logic once validation has passed.

That way, I can single out the upload logic, and work on the DB/validation part in two separate steps, so that the UL won’t happen unless the rest of the data has passed validation.

Thanks either way for the function, it will come in handy at another point smile cheers!
 
LuckyFella73
Posted: 04 November 2010 08:08 AM   [ Ignore ]   [ # 3 ]   [ Rating: 0 ]
Avatar
Joined: 2006-03-25
1011 posts

If I got you right you want to validate form-data and only if a file
was selected validate the file too. In that case you could do something like this:

<?php

class Jobs extends Controller {

    function Jobs()
    {
        parent::Controller();
        $this->load->model('main_model');
        $this->load->model('jobs_model');

        $this->upload_path = './../pdf/jobs/';
        $this->allowed_types = 'pdf';
        $this->max_size = 2024;
        $this->filename_temp = 'PDFj08sdf8u43jfs94j8fs94jflshf';
        $this->filename = $this->filename_temp;


    }

    function index()
    {
        #
    }

    function add()
    {
        $this->load->library('form_validation');

        $this->form_validation->set_rules('titel', 'Titel', 'trim');
        $this->form_validation->set_rules('text', 'Text', 'trim');


        # in case a file was selected
        if (isset($_FILES['userfile']['name']) AND strlen($_FILES['userfile']['name'])>1)
        {
            $this->form_validation->set_rules('userfile', 'PDF', 'trim|callback__upload_pdf');
        }

        if ($this->form_validation->run() == FALSE)
        {
            $this->load->view('view_form', $data);
        }
        else
        {
            // if no file was selected leave the entry for DB emtpy
            if ($this->filename == $this->filename_temp)
            {
                $this->filename = '';
            }

            // save into DB
            $data_db = array(
                'titel' => $this->input->post('titel'),
                'text' => $this->input->post('text'),
                'pdf' => $this->filename
            );
            if ( $this->jobs_model->add_job($this->tbl_jobs, $data_db) === FALSE )
            {
                $data['msg'] = 'DB error while saving data';
                $this->load->view('view_form', $data);
            }

            redirect('jobs', 'refresh');
        }
    }
    
    # CALLBACK:
    function _upload_pdf()
    {
        $config['upload_path'] = $this->upload_path;
        $config['allowed_types'] = $this->allowed_types;
        $config['max_size'] = $this->max_size;
        $field_name = 'userfile';

        $this->load->library('upload', $config);
        if (!$this->upload->do_upload($field_name))
        {
            $this->form_validation->set_message('_upload_pdf', $this->upload->display_errors());
            return FALSE;
        }
        else
        {
            $filedata = $this->upload->data();
            $this->filename = $filedata['file_name'];
            return TRUE;
        }
    }

    
}
/* End of file jobs.php */
/* Location: ./system/application/controllers/jobs.php */ 

The code is just a part of my whole controller file but should work
basically.
 
bravonet
Posted: 07 November 2010 10:48 AM   [ Ignore ]   [ # 4 ]   [ Rating: 0 ]
Joined: 2010-11-07
2 posts
umefarooq - 04 November 2010 11:15 AM

hope this will help you to solve your problem check the file validation

http://devbro.com/testing/ci_form_validation/

elo, i am quite new to codeigniter

i have some problem with multiple uploader validaion

i tried to make it like

for ($i=0; $i < $num_files ; $i++) {
        $this->form_validation->set_rules("userfile[$i]","Image","file_required|file_size_max[2048KB]|file_size_min[10KB]|file_allowed_type[image]");
    } 

and its seem like the validation is not working